Check for null exit status #1047
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
+ Coverage 67.60% 67.83% +0.22%
==========================================
Files 112 112
Lines 6582 6582
==========================================
+ Hits 4450 4465 +15
+ Misses 2132 2117 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -133,7 +133,7 @@ def generate_failure_report(self): | |||
| """Generate a html for reporting the failure of the `QeAppWorkChain`.""" | |||
| if not (process_node := self.fetch_process_node()): | |||
There was a problem hiding this comment.
suggestion ,
if not process_node or not process_node.exit_status:
return
edan-bainglass
force-pushed
the
summary-bug-fix
branch
from
e1e69d6 to
3abd04f
Compare
|
@AndresOrtegaGuerrero failing tests unrelated. Something about a deprecation that took place 01.01.2025. Will open an issue. |
|
Could you suggest how to test this ? |
I'm assuming you refer to the PR, not the failed tests. To test, you could simply remove the check and run a calculation. I encountered the issue when running my typical test workflow (relax positions + bands + pdos). |
Only escaped if exit status was 0, but need to escape if it is
None